2026-01-23 06:03:12 +00:00
|
|
|
# Claude Code Instructions
|
|
|
|
|
|
|
|
|
|
@AGENTS.md
|
|
|
|
|
|
|
|
|
|
## PR Review Guidelines
|
|
|
|
|
|
|
|
|
|
When reviewing PRs, follow these priorities:
|
|
|
|
|
|
|
|
|
|
### CRITICAL - Always comment:
|
|
|
|
|
- Logic errors or bugs that will cause failures
|
|
|
|
|
- Security vulnerabilities
|
|
|
|
|
- Test method names with typos (won't be discovered by test runner)
|
|
|
|
|
- Breaking changes without migration path
|
|
|
|
|
|
|
|
|
|
### SKIP - Don't comment on:
|
|
|
|
|
- Code style or formatting (we have linters for this)
|
|
|
|
|
- Suggestions for additional features or refactoring
|
|
|
|
|
- "Consider" or "might want to" suggestions
|
|
|
|
|
- Performance optimizations without profiling data
|
|
|
|
|
- Duplicate concerns (one comment per issue)
|
|
|
|
|
|
|
|
|
|
### Process:
|
|
|
|
|
1. Check if previous comments on same lines are now fixed - resolve those first
|
|
|
|
|
2. Limit to 5-7 high-signal comments per review
|
|
|
|
|
3. Group related issues into one comment when possible
|
|
|
|
|
4. If many issues exist, use a summary comment instead of 20+ inline comments
|
2026-01-27 06:24:07 +00:00
|
|
|
|
|
|
|
|
## Formatting & Linting (prek)
|
|
|
|
|
|
|
|
|
|
When asked to fix formatting, linting, or pre-commit issues (e.g., "fix prek", "fix formatting", "run pre-k"):
|
|
|
|
|
|
|
|
|
|
1. Run `uv run prek run --all-files` to auto-fix formatting issues
|
|
|
|
|
2. If prek modifies files, stage them with `git add .`
|
|
|
|
|
3. Commit with message: `fix: auto-format with prek`
|
|
|
|
|
4. Push the changes with `git push`
|
|
|
|
|
5. Comment on the PR confirming what was fixed
|
|
|
|
|
|
|
|
|
|
Do NOT just review the code - actually run prek and push the fixes!
|
