Commit graph

1465 commits

Author SHA1 Message Date
HeshamHM28
ea23cf06a6
fix: skip Python validation for Java/JS in optimize-line-profiler endpoint (#2478)
## Summary
- Fix `/optimize-line-profiler` endpoint rejecting Java/JS/TS requests
with `"Invalid Python version"` error by moving `parse_python_version()`
and Python syntax validation inside `if is_python:` block
- Fix code extraction regex in Java and JS/TS line profiler optimizers
to handle LLM responses with ```` ```java:FileName.java ```` format
(optional `:filename` suffix)

---------

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: HeshamHM28 <HeshamHM28@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-10 18:31:08 -07:00
Kevin Turcios
d74da02e57
fix: return display-version tests as generated_tests in testgen response (#2477)
## Summary
- The `/testgen` response's `generated_tests` field contained the
assert-removed version with `codeflash_output` assignments
- When the CLI's testgen review fell back to this field (instead of
`raw_generated_tests`), the review LLM flagged every test as a "no-op
assignment"
- Now returns the display version (asserts kept, no instrumentation) as
`generated_tests`, matching what the repair endpoint already does
- Also applies isort to the display source for consistency
2026-03-07 13:21:09 -06:00
Kevin Turcios
42b8eed7b4
fix: greedy code extraction with retry & fix unawaited coroutine in Java optimizer (#2476)
## Summary
- Use greedy code extraction and retry on syntax errors in testgen
repair
- Fix broken `asyncio.to_thread(log_features)` in Java optimizer —
`log_features` is `@sync_to_async` so calling it via `to_thread` created
an unawaited coroutine (`RuntimeWarning: coroutine
'SyncToAsync.__call__' was never awaited`) and silently skipped logging.
Replaced with `await log_features(...)` using correct keyword arguments.

## Test plan
- [ ] Verify testgen repair handles syntax errors with retry
- [ ] Verify Java optimization requests no longer emit `SyncToAsync`
RuntimeWarning
- [ ] Verify Java optimization features are correctly logged to DB
2026-03-07 03:18:43 -05:00
Kevin Turcios
0ca3a2ab07
fix: use greedy code extraction and retry on syntax errors in repair (#2475)
## Summary
- Switch `extract_code_block_with_context` (non-greedy `.*?`) →
`extract_code_block` (greedy `.*`) for repair code extraction — the
non-greedy regex matched the first closing fence, truncating code when
the LLM included explanatory snippets before the full file (root cause
of 82% of repair failures)
- Add `ast.parse` validation before CST parsing for fast syntax checking
- Retry the LLM once with the specific syntax error appended to the
conversation when validation fails

## Test plan
- [x] Existing tests pass
- [ ] Run end-to-end optimization to verify repairs succeed
2026-03-06 06:24:31 -05:00
Kevin Turcios
07edfaa0bd
fix: testgen prompt improvements (#2474)
## Summary

- Add multiline string literal constraint to testgen and repair prompts
— LLM was consistently generating unterminated string literals by
splitting strings across lines without triple quotes
- Deduplicate anthropic/markdown branches in testgen prompt templates —
single flow with inline `{% if is_xml %}` wrappers instead of duplicated
content

## Test plan

- [x] Verified templates render correctly for both anthropic and openai
model types (sync and async)
- [x] All block overrides from child templates work with the unified
block names
2026-03-06 10:54:50 +00:00
Kevin Turcios
434fb7df77
feat: improve testgen review & repair quality (#2473)
## Summary

- Pass coverage details (unexecuted lines, threshold) to review and
repair prompts so the LLM can identify low-coverage tests
- Accept previous repair errors in the repair endpoint and include them
in the prompt for retry cycles
- Parallelize per-test review LLM calls with `asyncio.TaskGroup`
- Conditionally include codeflash env var context
(`CODEFLASH_TRACER_DISABLE`, etc.) in repair prompts when the function
under test references them

## Test plan

- [x] Tested locally with codeflash CLI against `Tracer.__enter__` —
review, repair, and retry cycles all work
- [x] Coverage details and previous errors appear correctly in prompts
- [x] Review parallelization reduces latency from sequential ~60s per
test to concurrent
2026-03-06 10:23:55 +00:00
Kevin Turcios
14c0b3acca
fix: handle syntactically invalid LLM output in testgen repair (#2472)
## Summary
- Catch `ParserSyntaxError` when parsing LLM-repaired code instead of
letting it bubble to the generic 500 handler
- Reduces Sentry noise from expected LLM failures
- The CLI already handles non-200 responses gracefully (returns `None`,
continues)
2026-03-06 07:32:30 +00:00
Kevin Turcios
4edd183d82
perf: use Haiku model for testgen repair (#2471)
## Summary
- Switch testgen repair endpoint from `EXECUTE_MODEL` (GPT-5-Mini) to
`HAIKU_MODEL` (Haiku 4.5)
- Matches the review endpoint which already uses Haiku
- Repair is a structured task (splice functions, fix assertions) that
doesn't need a frontier model
- Should reduce latency (was timing out at 90s in CI) and cost
2026-03-06 07:10:44 +00:00
claude[bot]
6c7377a71f fix: resolve duplicate kwargs and missing HttpError import in testgen_repair 2026-03-05 22:14:28 +00:00
Kevin Turcios
641e609bda
Merge branch 'main' into testgen-review-repair 2026-03-05 22:09:37 +00:00
Kevin Turcios
de109c6e12
Update django/aiservice/core/shared/testgen_review/repair.py
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-03-05 17:09:28 -05:00
Kevin Turcios
737a270801
Update django/aiservice/core/shared/testgen_review/repair.py
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
2026-03-05 17:09:17 -05:00
Kevin Turcios
d9a963d305 fix: resolve contradicting response format instructions in multi-file prompt 2026-03-05 07:59:39 -05:00
Kevin Turcios
9a979439f1 fix: clarify multi-file prompt to identify target file and reduce context noise
Tell the LLM the first file is the optimization target and remaining
files are context only. Allow omitting unchanged context files from
the response.
2026-03-05 05:59:41 -05:00
Kevin Turcios
8106d53e32 Merge remote-tracking branch 'origin/testgen-review-repair' into testgen-review-repair 2026-03-04 14:30:01 -05:00
Kevin Turcios
1532a66278 feat: include coverage info in test review and improve review prompt
Accept coverage_summary in the review schema and pass it to the prompt.
Add two new review criteria: low coverage detection and constructor/
dependency error patterns. Coverage percentage is shown in the user
prompt so the reviewer can flag tests that don't exercise the function.
2026-03-04 14:14:19 -05:00
claude[bot]
f31b428a72 style: auto-fix linting issues 2026-03-04 09:15:27 +00:00
Kevin Turcios
ff35883ce6 Merge remote-tracking branch 'origin/testgen-review-repair' into testgen-review-repair 2026-03-04 04:13:24 -05:00
Kevin Turcios
644ded986f Merge remote-tracking branch 'origin/main' into testgen-review-repair 2026-03-04 04:10:56 -05:00
Kevin Turcios
c2a67e8137 feat: pass test failure messages to review endpoint for better context
Include runtime error messages from behavioral test failures in the
review request. Failed function verdicts now include the specific error
message. The review prompt shows error details so the AI can see
patterns like type validation failures.
2026-03-04 04:09:27 -05:00
Kevin Turcios
fce866c96f fix: splice only flagged functions from LLM repair into original test source
Instead of replacing the entire test file with the LLM's output, parse
both the original and repaired sources as CST, extract only the flagged
function nodes from the repair output, and surgically replace them in
the original. Unflagged functions are preserved exactly as-is.
2026-03-04 03:26:03 -05:00
Kevin Turcios
33be205d88 feat: run postprocessing pipeline on repaired tests before instrumentation
Repaired tests from the LLM now go through the same postprocessing
pipeline as initial generation (import fixing, loop limiting, unused
definition removal) before instrumentation. Returns the display version
(with asserts) as generated_tests for client-side display.
2026-03-04 03:20:09 -05:00
claude[bot]
8fe3171934 fix: resolve mypy type errors in generate.py and postprocess_pipeline.py 2026-03-04 08:19:57 +00:00
Kevin Turcios
2899eae4da feat: return display-ready test source with asserts in testgen response
Split postprocessing_testgen_pipeline to capture the test source before
assert removal — fully cleaned (imports, loops, definitions) but with
original asserts intact. Return it as raw_generated_tests in the
TestGenResponseSchema so the CLI can display the human-readable version.
2026-03-04 03:16:30 -05:00
Kevin Turcios
40f3236645 refactor: simplify template selection with string composition 2026-03-04 01:13:06 -05:00
Kevin Turcios
c2f9b17969 Merge remote-tracking branch 'origin/main' into fix-js-async-testgen-flaky-tests 2026-03-04 01:09:00 -05:00
claude[bot]
38ca8824d6 fix: resolve mypy type errors in code_repair_context 2026-03-03 23:29:13 +00:00
Aseem Saxena
16253b3d63
Merge branch 'main' into match-testdiff-schema 2026-03-04 04:56:29 +05:30
Sarthak Agarwal
cc32654b7f
mocha prompts in backend (#2468)
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
2026-03-04 04:09:10 +05:30
HeshamHM28
44fc7dc8e8
feat: Add support for specifying target Java version in test generation (#2445) 2026-03-03 22:03:29 +00:00
aseembits93
4e60026fcc test 2026-03-03 05:53:34 +05:30
Kevin Turcios
04624cc389 relax 2026-03-02 19:22:55 -05:00
Kevin Turcios
5d2ad27d3f refactor: extract shared create_prompt_env Jinja2 factory
Deduplicate the identical Environment(FileSystemLoader, StrictUndefined,
keep_trailing_newline=True) setup across JS testgen, Python testgen, and
Python explanations into core/shared/jinja_utils.py.

Also fix tests/testgen/test_testgen_javascript.py which had a stale
copy of build_javascript_prompt and loaded the now-deleted .md files.
2026-03-02 18:42:57 -05:00
Kevin Turcios
7820fb15e1 refactor: move ESM/CJS import formatting from Python to Jinja2 macro
Split _generate_import_statement into _resolve_import (pure logic:
identifier validation, dot splitting, reserved words) and a js_import
Jinja2 macro (pure formatting: ESM vs CJS syntax). The macro lives in
_macros.md.j2 and is imported by user.md.j2.
2026-03-02 18:28:30 -05:00
Kevin Turcios
d00fa99cc5 feat: convert JS/TS testgen prompts to Jinja2 templates with model_type and ESM support
Replace plain .md prompts rendered with str.format() with Jinja2
templates using {% extends %}, {% block %}, and {% if %} branching:

- model_type branching: XML tags for Anthropic, markdown headers for OpenAI
- module_system support: ESM imports (import { fn } from '...') vs CJS (require)
- Template inheritance: base_system.md.j2 with sync/async overrides
- Unified user.md.j2 with is_async and module_system conditionals
- Add module_system field to TestGenSchema
2026-03-02 18:23:30 -05:00
Kevin Turcios
4cdcd57f04 fix: reduce flaky generated tests for JS async functions
The async testgen prompt was steering the LLM toward generating
timing-dependent and ordering-sensitive tests that produce
non-deterministic results across runs. This caused ~50% E2E failure
rate for the JS ESM async workflow.

- Add determinism requirement: never assert on timing, elapsed
  duration, or relative ordering of async side effects
- Remove directive to use Promise.all() for large-scale tests
- Change large-scale objective from "concurrent operations" to
  "correctness with larger inputs"
- Replace concurrent execution template example with a simple
  large-input correctness test
2026-03-02 17:47:20 -05:00
claude[bot]
962edcc595 fix: correct unpacking of validate_request_data return value
Co-authored-by: Kevin Turcios <KRRT7@users.noreply.github.com>
2026-03-02 16:01:04 +00:00
claude[bot]
3f49aa1b43 fix: resolve mypy type errors in generate.py 2026-03-02 08:58:37 -05:00
Kevin Turcios
87ab144d40 feat: per-function test review + repair endpoints
Add POST /ai/testgen_review and POST /ai/testgen_repair endpoints.
Review accepts per-test data with pre-flagged behavioral failures, AI
reviews passing functions for unrealistic patterns, returns per-function
verdicts. Repair takes flagged functions, LLM rewrites them,
re-instruments, returns repaired test source. Python-only gate.
2026-03-02 08:54:44 -05:00
Kevin Turcios
efa29bf452 refactor: split instrument_new_tests.py into focused modules and extract model selection
Split the 1,734-line instrument_new_tests.py into three modules by concern:
- device_sync.py: GPU/device framework detection and sync AST generation
- wrapper.py: wrapper function generation, unified inject_logging_code, format_and_float_to_top
- instrument_new_tests.py: core AST transformer (InjectPerfAndLogging) and instrument_test_source

Also extract select_model_for_test() from testgen_python() in generate.py to
separate model selection logic from the HTTP handler.
2026-03-02 08:21:02 -05:00
Kevin Turcios
e26dd72d7d refactor: remove duplicate replace_definition_with_import from parse_and_validate_llm_output
The call was redundant — the postprocessing pipeline already handles it as
its final step. Move the test coverage to test_postprocessing_pipeline.py.
2026-03-02 07:58:54 -05:00
Kevin Turcios
0541126fc0 refactor: eliminate BaseTestGenContext class hierarchy
Replace class hierarchy (BaseTestGenContext → Single/Multi) with
standalone functions that branch on is_multi_context() internally.
Delete context.py, move TestGenContextData to models.py, and
distribute logic to validate.py, preprocess_pipeline.py, and
generate.py.
2026-03-02 07:38:51 -05:00
Kevin Turcios
a1c0ac6ae4 refactor: leverage Jinja2 includes, extends, and composition in testgen prompts
Use {% extends %} to deduplicate sync/async system templates via
base_system.md.j2, {% include %} for conditional JIT content, and a
compose_user.md.j2 wrapper to replace Python string assembly in
build_prompt().
2026-03-02 07:26:38 -05:00
Kevin Turcios
f191c12438 refactor: reorganize python testgen directory structure
Move prompts into prompts/ subdirectory with clearer names, rename
testgen.py to generate.py, extract validate.py and demo_hacks.py,
rename testgen_context.py to context.py, delete unused explain prompts.
2026-03-02 06:39:07 -05:00
Sarthak Agarwal
4b88fc0cc7
llm call optimization fail error log and small refactoring (#2447) 2026-03-02 12:33:56 +05:30
claude[bot]
3309dcec2c fix: resolve mypy type errors in explanations.py
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-27 20:10:19 +00:00
claude[bot]
49e11a585a style: auto-fix formatting issues
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-27 20:08:28 +00:00
Kevin Turcios
ded2240818
Merge branch 'main' into allocs 2026-02-27 20:06:57 +00:00
Kevin Turcios
779fda2b36 slight changes 2026-02-27 15:02:08 -05:00
Kevin Turcios
1fedb8c443 refactor: rewrite explanation prompts with Jinja2 macros and tighter brevity constraints
- Extract shared content into Jinja2 macros (`section`, `field`,
  `code_field`) that handle Anthropic XML vs OpenAI markdown wrapping,
  eliminating full duplication of every section across both branches
- Tighten system prompt to enforce concise 3-6 sentence output: trim
  bloated per-field context descriptions, add concrete positive example,
  explicitly forbid section headers and bullet groups, move output_format
  to be the last section so constraints are closest to generation
- Add caveat that original_explanation is for factual reference only (in
  both system and user prompts) to prevent the model from mimicking its
  verbose multi-section format
- Condense throughput/concurrency/acceptance sections to essentials
- Rename misleading `## CRITICAL` heading to `## Acceptance Criteria`
2026-02-27 14:38:24 -05:00