codeflash-admin/codeflash
1
0
Fork 0
mirror of https://github.com/codeflash-ai/codeflash.git synced 2026-05-04 18:25:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: decode help-banner test subprocess output as UTF-8

Browse source 
Rich renders the banner panel with box-drawing characters (╭, ╮, │, etc.)
that cp1252 cannot decode. On Windows, subprocess.run(..., text=True) uses
cp1252 by default, so decoding the child stdout raises UnicodeDecodeError
and subprocess sets result.stdout to None — breaking the assertion with a
misleading "argument of type 'NoneType' is not iterable".

Pass encoding="utf-8" explicitly so the test passes on every platform.
This commit is contained in:
Mohamed Ashraf 2026-04-28 16:39:00 +00:00
parent 1d83f7cb15
commit 0d1e2a7e51
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/test_help_banner.py
View file

@ -4,7 +4,10 @@ import sys
def test_help_displays_logo() -> None:
result = subprocess.run(
[sys.executable, "-c", "from codeflash.main import main; main()", "--help"], capture_output=True, text=True
[sys.executable, "-c", "from codeflash.main import main; main()", "--help"],
capture_output=True,
text=True,
encoding="utf-8",
)
assert result.returncode == 0
assert "codeflash.ai" in result.stdout
@ -12,7 +15,10 @@ def test_help_displays_logo() -> None:
def test_help_short_flag_displays_logo() -> None:
result = subprocess.run(
[sys.executable, "-c", "from codeflash.main import main; main()", "-h"], capture_output=True, text=True
[sys.executable, "-c", "from codeflash.main import main; main()", "-h"],
capture_output=True,
text=True,
encoding="utf-8",
)
assert result.returncode == 0
assert "codeflash.ai" in result.stdout