codeflash-admin/codeflash
1
0
Fork 0
mirror of https://github.com/codeflash-ai/codeflash.git synced 2026-05-04 18:25:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove python_version from API payloads

Browse source 
Use language_version exclusively — the backend now resolves
python_version from language_version for backward compatibility.
This commit is contained in:
Kevin Turcios 2026-03-27 02:53:22 -05:00
parent 32575780bd
commit 66f1dab2ba
2 changed files with 6 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
codeflash/api/aiservice.py
View file

@ -62,7 +62,6 @@ class AiServiceClient:
if language_version is None:
language_version = current_language_support().language_version
payload["language_version"] = language_version
payload["python_version"] = language_version if current_language() == Language.PYTHON else None
if current_language() != Language.PYTHON:
if module_system:
@ -270,7 +269,6 @@ class AiServiceClient:
"trace_id": trace_id,
"language": language,
"language_version": language_version,
"python_version": language_version if current_language() == Language.PYTHON else None,
"experiment_metadata": experiment_metadata,
"codeflash_version": codeflash_version,
"call_sequence": self.get_next_sequence(),
@ -534,7 +532,6 @@ class AiServiceClient:
"diffs": diffs,
"speedups": speedups,
"optimization_ids": optimization_ids,
"python_version": platform.python_version(), # backward compat
"function_references": function_references,
}
logger.info("loading|Generating ranking")
@ -844,7 +841,6 @@ class AiServiceClient:
"calling_fn_details": calling_fn_details,
"language": language,
"language_version": platform.python_version() if current_language() == Language.PYTHON else None,
"python_version": platform.python_version() if current_language() == Language.PYTHON else None,
"call_sequence": self.get_next_sequence(),
}
console.rule()

18
tests/test_add_language_metadata.py
View file

@ -18,12 +18,11 @@ class TestAddLanguageMetadata:
"""Test add_language_metadata sets correct payload fields per language."""
@patch("codeflash.api.aiservice.current_language", return_value=Language.PYTHON)
def test_python_sets_language_version_and_python_version(self, _mock_lang: object) -> None:
"""For Python, both language_version and python_version should be set to the same value."""
def test_python_sets_language_version(self, _mock_lang: object) -> None:
"""For Python, language_version should be set."""
payload: dict = {}
AiServiceClient.add_language_metadata(payload, language_version="3.11.5")
assert payload["language_version"] == "3.11.5"
assert payload["python_version"] == "3.11.5"
assert "module_system" not in payload
@patch("codeflash.api.aiservice.current_language", return_value=Language.PYTHON)
@ -34,12 +33,11 @@ class TestAddLanguageMetadata:
assert "module_system" not in payload
@patch("codeflash.api.aiservice.current_language", return_value=Language.JAVA)
def test_java_sets_language_version_not_python_version(self, _mock_lang: object) -> None:
"""For Java, language_version should be set, python_version should be None."""
def test_java_sets_language_version(self, _mock_lang: object) -> None:
"""For Java, language_version should be set."""
payload: dict = {}
AiServiceClient.add_language_metadata(payload, language_version="17")
assert payload["language_version"] == "17"
assert payload["python_version"] is None
@patch("codeflash.api.aiservice.current_language", return_value=Language.JAVA)
def test_java_includes_module_system(self, _mock_lang: object) -> None:
@ -56,12 +54,11 @@ class TestAddLanguageMetadata:
assert "module_system" not in payload
@patch("codeflash.api.aiservice.current_language", return_value=Language.JAVASCRIPT)
def test_javascript_sets_language_version_not_python_version(self, _mock_lang: object) -> None:
"""For JavaScript, language_version should be set, python_version should be None."""
def test_javascript_sets_language_version(self, _mock_lang: object) -> None:
"""For JavaScript, language_version should be set."""
payload: dict = {}
AiServiceClient.add_language_metadata(payload, language_version="20.11.0")
assert payload["language_version"] == "20.11.0"
assert payload["python_version"] is None
@patch("codeflash.api.aiservice.current_language", return_value=Language.JAVASCRIPT)
def test_javascript_includes_module_system(self, _mock_lang: object) -> None:
@ -76,7 +73,6 @@ class TestAddLanguageMetadata:
payload: dict = {}
AiServiceClient.add_language_metadata(payload, language_version="20.11.0", module_system="commonjs")
assert payload["language_version"] == "20.11.0"
assert payload["python_version"] is None
assert payload["module_system"] == "commonjs"
@patch("codeflash.api.aiservice.current_language", return_value=Language.PYTHON)
@ -87,7 +83,6 @@ class TestAddLanguageMetadata:
payload: dict = {}
AiServiceClient.add_language_metadata(payload, language_version=None)
assert payload["language_version"] == "3.12.0"
assert payload["python_version"] == "3.12.0"
@patch("codeflash.api.aiservice.current_language", return_value=Language.JAVA)
@patch("codeflash.api.aiservice.current_language_support")
@ -97,4 +92,3 @@ class TestAddLanguageMetadata:
payload: dict = {}
AiServiceClient.add_language_metadata(payload, language_version=None)
assert payload["language_version"] == "17"
assert payload["python_version"] is None