codeflash-ai/codeflash
1
0
Fork 0
Code Issues 18 Pull requests 33 Projects Releases Packages Wiki Activity Actions 3.1k

remove set while runnin formatters #131

Closed
codeflash-ai wants to merge 0 commits from formatter-runs-it-in-order into main
pull from: formatter-runs-it-in-order
merge into: codeflash-ai:main
Conversation 0 Commits - Files changed -
codeflash-ai commented 2026-05-05 00:27:20 +00:00
Owner
Copy link

PR Type

Bug fix

Description

  • Preserve formatter sequence order

  • Remove set-based deduplication of commands

  • Iterate original formatter_cmds list directly

  • Allow duplicate formatter invocations

Changes walkthrough 📝

Relevant files
Bug fix
formatter.py
Preserve formatter commands order                                               

codeflash/code_utils/formatter.py

  • Removed use of set() around formatter_cmds
  • Changed loop to iterate original list
  • Preserved command order and duplicates
    		• +1/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    • ### **PR Type** Bug fix ___ ### **Description** - Preserve formatter sequence order - Remove set-based deduplication of commands - Iterate original formatter_cmds list directly - Allow duplicate formatter invocations ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>formatter.py</strong><dd><code>Preserve formatter commands order</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> codeflash/code_utils/formatter.py <li>Removed use of set() around formatter_cmds<br> <li> Changed loop to iterate original list<br> <li> Preserved command order and duplicates </details> </td> <td><a href="https://github.com/codeflash-ai/codeflash/pull/252/files#diff-ead54b6ab4522d27ae1bc0af93885ab05a8f49ea3c96308972c17deaa97515d2">+1/-1</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details>
    codeflash-ai closed this pull request 2026-05-05 00:27:22 +00:00
    Some checks failed
    CodeFlash / Optimize new Python code (pull_request) Failing after 2s
    Details
    PR Labeler / label-workflow-changes (pull_request) Failing after 1s
    Details
    Mypy Type Checking for CLI / type-check-cli (pull_request) Failing after 2s
    Details
    / Run pr agent on every pull request, respond to user comments (pull_request) Failing after 1s
    Details
    Lint / Run pre-commit hooks (pull_request) Failing after 5s
    Details
    unit-tests / unit-tests (3.10) (pull_request) Failing after 2s
    Details
    unit-tests / unit-tests (3.11) (pull_request) Failing after 2s
    Details
    unit-tests / unit-tests (3.12) (pull_request) Failing after 1s
    Details
    unit-tests / unit-tests (3.9) (pull_request) Failing after 1s
    Details

    Pull request closed

    Please reopen this pull request to perform a merge.
    Sign in to join this conversation.
    Reviewers
    No reviewers
    Labels
    Clear labels   
    agentic-workflows

       
    bug

    Something isn't working

      
    ⚡️ codeflash

    Optimization PR opened by Codeflash AI

      
    codeflash:skip

    Skip CF run for the particular PR

      
    dependencies

    Pull requests that update a dependency file

      
    documentation

    Improvements or additions to documentation

      
    duplicate

    This issue or pull request already exists

      
    enhancement

    New feature or request

      
    github_actions

    Pull requests that update GitHub Actions code

      
    good first issue

    Good for newcomers

      
    help wanted

    Extra attention is needed

      
    invalid

    This doesn't seem right

      
    javascript

    Pull requests that update javascript code

      
    openhands

       
    python

    Pull requests that update python code

      
    python:uv

    Pull requests that update python:uv code

      
    🎯 Quality:

    Optimization Quality according to codeflash

      
    🎯 Quality: High

    Optimization Quality according to Codeflash

      
    🎯 Quality: Medium

    Optimization Quality according to codeflash

      
    question

    Further information is requested

      
    Review effort 1/5

       
    Review effort 2/5

       
    Review effort 3/5

       
    Review effort 4/5

       
    Review effort 5/5

       
    testing

       
    wontfix

    This will not be worked on

      
    workflow-modified

    This PR modifies GitHub Actions workflows

    No labels
    agentic-workflows
    bug
    ⚡️ codeflash
    codeflash:skip
    dependencies
    documentation
    duplicate
    enhancement
    github_actions
    good first issue
    help wanted
    invalid
    javascript
    openhands
    python
    python:uv
    🎯 Quality:
    🎯 Quality: High
    🎯 Quality: Medium
    question
    Review effort 1/5
    Review effort 2/5
    Review effort 3/5
    Review effort 4/5
    Review effort 5/5
    testing
    wontfix
    workflow-modified
    Milestone
    Clear milestone
    No items
    No milestone
    Projects
    Clear projects
    No items
    No project
    Assignees
    Clear assignees
    No assignees
    1 participant
    Notifications
    Due date
    The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

    No due date set.

    Dependencies

    No dependencies set.

    Reference: codeflash-ai/codeflash#131
    No description provided.
    Delete branch "formatter-runs-it-in-order"

    Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?