"""Tests for JavaScript/TypeScript project initialization and package manager detection."""
import json
from pathlib import Path
from unittest.mock import patch
import pytest
from codeflash.cli_cmds.init_javascript import (
JsPackageManager,
ProjectLanguage,
detect_project_language,
determine_js_package_manager,
get_package_install_command,
should_modify_package_json_config,
)
@pytest.fixture
def tmp_project(tmp_path: Path) -> Path:
"""Create a temporary project directory."""
return tmp_path
class TestDetermineJsPackageManager:
"""Tests for determine_js_package_manager function."""
def test_detects_pnpm_from_lockfile(self, tmp_project: Path) -> None:
"""Should detect pnpm from pnpm-lock.yaml."""
(tmp_project / "pnpm-lock.yaml").write_text("")
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.PNPM
def test_detects_yarn_from_lockfile(self, tmp_project: Path) -> None:
"""Should detect yarn from yarn.lock."""
(tmp_project / "yarn.lock").write_text("")
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.YARN
def test_detects_npm_from_lockfile(self, tmp_project: Path) -> None:
"""Should detect npm from package-lock.json."""
(tmp_project / "package-lock.json").write_text("{}")
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.NPM
def test_detects_bun_from_lockfile(self, tmp_project: Path) -> None:
"""Should detect bun from bun.lockb."""
(tmp_project / "bun.lockb").write_text("")
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.BUN
def test_detects_bun_from_bun_lock(self, tmp_project: Path) -> None:
"""Should detect bun from bun.lock."""
(tmp_project / "bun.lock").write_text("")
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.BUN
def test_defaults_to_npm_with_package_json_only(self, tmp_project: Path) -> None:
"""Should default to npm when only package.json exists."""
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.NPM
def test_returns_unknown_without_package_json(self, tmp_project: Path) -> None:
"""Should return UNKNOWN when no package.json exists."""
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.UNKNOWN
def test_pnpm_takes_precedence_over_npm(self, tmp_project: Path) -> None:
"""Should prefer pnpm when both lockfiles exist (migration scenario)."""
(tmp_project / "pnpm-lock.yaml").write_text("")
(tmp_project / "package-lock.json").write_text("{}")
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.PNPM
def test_bun_takes_precedence_over_others(self, tmp_project: Path) -> None:
"""Should prefer bun when bun.lockb exists alongside others."""
(tmp_project / "bun.lockb").write_text("")
(tmp_project / "pnpm-lock.yaml").write_text("")
(tmp_project / "package.json").write_text("{}")
result = determine_js_package_manager(tmp_project)
assert result == JsPackageManager.BUN
# Monorepo tests - lock file in parent directory
def test_detects_pnpm_from_parent_lockfile(self, tmp_project: Path) -> None:
"""Should detect pnpm from pnpm-lock.yaml in parent directory (monorepo)."""
# Create monorepo structure: root/packages/my-package
workspace_root = tmp_project
package_dir = workspace_root / "packages" / "my-package"
package_dir.mkdir(parents=True)
# Lock file at workspace root
(workspace_root / "pnpm-lock.yaml").write_text("")
(workspace_root / "package.json").write_text("{}")
# Package has its own package.json but no lock file
(package_dir / "package.json").write_text("{}")
result = determine_js_package_manager(package_dir)
assert result == JsPackageManager.PNPM
def test_detects_yarn_from_parent_lockfile(self, tmp_project: Path) -> None:
"""Should detect yarn from yarn.lock in parent directory (monorepo)."""
workspace_root = tmp_project
package_dir = workspace_root / "packages" / "my-package"
package_dir.mkdir(parents=True)
(workspace_root / "yarn.lock").write_text("")
(workspace_root / "package.json").write_text("{}")
(package_dir / "package.json").write_text("{}")
result = determine_js_package_manager(package_dir)
assert result == JsPackageManager.YARN
def test_detects_npm_from_parent_lockfile(self, tmp_project: Path) -> None:
"""Should detect npm from package-lock.json in parent directory (monorepo)."""
workspace_root = tmp_project
package_dir = workspace_root / "packages" / "my-package"
package_dir.mkdir(parents=True)
(workspace_root / "package-lock.json").write_text("{}")
(workspace_root / "package.json").write_text("{}")
(package_dir / "package.json").write_text("{}")
result = determine_js_package_manager(package_dir)
assert result == JsPackageManager.NPM
def test_detects_bun_from_parent_lockfile(self, tmp_project: Path) -> None:
"""Should detect bun from bun.lockb in parent directory (monorepo)."""
workspace_root = tmp_project
package_dir = workspace_root / "packages" / "my-package"
package_dir.mkdir(parents=True)
(workspace_root / "bun.lockb").write_text("")
(workspace_root / "package.json").write_text("{}")
(package_dir / "package.json").write_text("{}")
result = determine_js_package_manager(package_dir)
assert result == JsPackageManager.BUN
def test_local_lockfile_takes_precedence_over_parent(self, tmp_project: Path) -> None:
"""Should prefer local lock file over parent directory lock file."""
workspace_root = tmp_project
package_dir = workspace_root / "packages" / "my-package"
package_dir.mkdir(parents=True)
# Parent has pnpm, but local package has yarn
(workspace_root / "pnpm-lock.yaml").write_text("")
(workspace_root / "package.json").write_text("{}")
(package_dir / "yarn.lock").write_text("")
(package_dir / "package.json").write_text("{}")
result = determine_js_package_manager(package_dir)
# Should detect yarn from local directory first
assert result == JsPackageManager.YARN
def test_deeply_nested_package_finds_root_lockfile(self, tmp_project: Path) -> None:
"""Should find lock file in deeply nested monorepo structure."""
workspace_root = tmp_project
# Simulate: root/apps/web/src/features/auth
deep_dir = workspace_root / "apps" / "web" / "src" / "features" / "auth"
deep_dir.mkdir(parents=True)
(workspace_root / "pnpm-lock.yaml").write_text("")
(workspace_root / "package.json").write_text("{}")
result = determine_js_package_manager(deep_dir)
assert result == JsPackageManager.PNPM
class TestGetPackageInstallCommand:
"""Tests for get_package_install_command function."""
def test_npm_install_command(self, tmp_project: Path) -> None:
"""Should return npm install command for npm projects."""
(tmp_project / "package-lock.json").write_text("{}")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=True)
assert result == ["npm", "install", "codeflash", "--save-dev"]
def test_npm_install_command_non_dev(self, tmp_project: Path) -> None:
"""Should return npm install command without --save-dev when dev=False."""
(tmp_project / "package-lock.json").write_text("{}")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=False)
assert result == ["npm", "install", "codeflash"]
def test_pnpm_add_command(self, tmp_project: Path) -> None:
"""Should return pnpm add command for pnpm projects."""
(tmp_project / "pnpm-lock.yaml").write_text("")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=True)
assert result == ["pnpm", "add", "codeflash", "--save-dev"]
def test_pnpm_add_command_non_dev(self, tmp_project: Path) -> None:
"""Should return pnpm add command without --save-dev when dev=False."""
(tmp_project / "pnpm-lock.yaml").write_text("")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=False)
assert result == ["pnpm", "add", "codeflash"]
def test_yarn_add_command(self, tmp_project: Path) -> None:
"""Should return yarn add command for yarn projects."""
(tmp_project / "yarn.lock").write_text("")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=True)
assert result == ["yarn", "add", "codeflash", "--dev"]
def test_yarn_add_command_non_dev(self, tmp_project: Path) -> None:
"""Should return yarn add command without --dev when dev=False."""
(tmp_project / "yarn.lock").write_text("")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=False)
assert result == ["yarn", "add", "codeflash"]
def test_bun_add_command(self, tmp_project: Path) -> None:
"""Should return bun add command for bun projects."""
(tmp_project / "bun.lockb").write_text("")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=True)
assert result == ["bun", "add", "codeflash", "--dev"]
def test_bun_add_command_non_dev(self, tmp_project: Path) -> None:
"""Should return bun add command without --dev when dev=False."""
(tmp_project / "bun.lockb").write_text("")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "codeflash", dev=False)
assert result == ["bun", "add", "codeflash"]
def test_defaults_to_npm_for_unknown(self, tmp_project: Path) -> None:
"""Should default to npm for unknown package manager."""
# No lockfile, no package.json - unknown package manager
result = get_package_install_command(tmp_project, "codeflash", dev=True)
assert result == ["npm", "install", "codeflash", "--save-dev"]
def test_different_package_name(self, tmp_project: Path) -> None:
"""Should work with different package names."""
(tmp_project / "pnpm-lock.yaml").write_text("")
(tmp_project / "package.json").write_text("{}")
result = get_package_install_command(tmp_project, "typescript", dev=True)
assert result == ["pnpm", "add", "typescript", "--save-dev"]
class TestShouldModifySkipConfirm:
"""Tests for should_modify_package_json_config with skip_confirm."""
def test_should_modify_skip_confirm_no_config(self, tmp_project: Path, monkeypatch: pytest.MonkeyPatch) -> None:
"""With skip_confirm and no codeflash config, should return (True, None)."""
monkeypatch.chdir(tmp_project)
(tmp_project / "package.json").write_text(json.dumps({"name": "test"}))
should_modify, config = should_modify_package_json_config(skip_confirm=True)
assert should_modify is True
assert config is None
def test_should_modify_skip_confirm_with_valid_config(
self, tmp_project: Path, monkeypatch: pytest.MonkeyPatch
) -> None:
"""With skip_confirm and valid config, should return (False, config) — no reconfigure."""
monkeypatch.chdir(tmp_project)
codeflash_config = {"moduleRoot": "."}
(tmp_project / "package.json").write_text(json.dumps({"name": "test", "codeflash": codeflash_config}))
should_modify, config = should_modify_package_json_config(skip_confirm=True)
assert should_modify is False
assert config == codeflash_config
def test_should_modify_skip_confirm_with_invalid_config(
self, tmp_project: Path, monkeypatch: pytest.MonkeyPatch
) -> None:
"""With skip_confirm and invalid config (bad moduleRoot), should return (True, None)."""
monkeypatch.chdir(tmp_project)
codeflash_config = {"moduleRoot": "/nonexistent/path/that/does/not/exist"}
(tmp_project / "package.json").write_text(json.dumps({"name": "test", "codeflash": codeflash_config}))
should_modify, config = should_modify_package_json_config(skip_confirm=True)
assert should_modify is True
assert config is None
class TestCollectJsSetupInfoSkipConfirm:
"""Tests for collect_js_setup_info with skip_confirm."""
def test_collect_js_setup_info_skip_confirm(self, tmp_project: Path, monkeypatch: pytest.MonkeyPatch) -> None:
"""skip_confirm should return defaults without any interactive prompts."""
monkeypatch.chdir(tmp_project)
(tmp_project / "package.json").write_text(json.dumps({"name": "test"}))
from codeflash.cli_cmds.init_javascript import ProjectLanguage, collect_js_setup_info
# Should not call any prompt functions
with patch("codeflash.cli_cmds.init_javascript.inquirer") as mock_inquirer:
setup_info = collect_js_setup_info(ProjectLanguage.JAVASCRIPT, skip_confirm=True)
mock_inquirer.prompt.assert_not_called()
assert setup_info.module_root_override is None
assert setup_info.formatter_override is None
assert setup_info.git_remote == "origin"
class TestDetectProjectLanguage:
"""Tests for detect_project_language function."""
def test_detects_java_from_pom_xml(self, tmp_project: Path) -> None:
(tmp_project / "pom.xml").write_text("")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVA
def test_detects_java_from_build_gradle(self, tmp_project: Path) -> None:
(tmp_project / "build.gradle").write_text("")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVA
def test_detects_java_from_build_gradle_kts(self, tmp_project: Path) -> None:
(tmp_project / "build.gradle.kts").write_text("")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVA
def test_detects_typescript_from_tsconfig(self, tmp_project: Path) -> None:
(tmp_project / "tsconfig.json").write_text("{}")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.TYPESCRIPT
def test_detects_javascript_from_package_json(self, tmp_project: Path) -> None:
(tmp_project / "package.json").write_text("{}")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVASCRIPT
def test_detects_python_from_pyproject_toml(self, tmp_project: Path) -> None:
(tmp_project / "pyproject.toml").write_text("")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.PYTHON
def test_defaults_to_python_for_empty_directory(self, tmp_project: Path) -> None:
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.PYTHON
def test_java_takes_priority_over_python(self, tmp_project: Path) -> None:
(tmp_project / "pom.xml").write_text("")
(tmp_project / "pyproject.toml").write_text("")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVA
def test_java_takes_priority_over_javascript(self, tmp_project: Path) -> None:
(tmp_project / "build.gradle").write_text("")
(tmp_project / "package.json").write_text("{}")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVA
def test_java_takes_priority_over_typescript(self, tmp_project: Path) -> None:
(tmp_project / "pom.xml").write_text("")
(tmp_project / "tsconfig.json").write_text("{}")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVA
def test_javascript_with_js_indicators_over_python(self, tmp_project: Path) -> None:
(tmp_project / "package.json").write_text("{}")
(tmp_project / "pyproject.toml").write_text("")
(tmp_project / "node_modules").mkdir()
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.JAVASCRIPT
def test_python_over_package_json_without_js_indicators(self, tmp_project: Path) -> None:
(tmp_project / "package.json").write_text("{}")
(tmp_project / "pyproject.toml").write_text("")
result = detect_project_language(tmp_project)
assert result == ProjectLanguage.PYTHON